Matthias Möller
12cdbb712c
Fixes possible out-of-bound read in findDegenerate ( #5679 )
...
This is possible, if the option "aiProcess_ValidateDataStructure" is deactivated as postprocessing step, but the option "aiProcess_FindDegenerates" is activated and the mesh contains invalid data structures
Co-authored-by: Kim Kulling <kimkulling@users.noreply.github.com>
2024-08-13 16:24:43 +02:00
Kim Kulling
104a70f845
Return false instead of crash ( #5685 )
...
- Return false instead of crash
- closes https://github.com/assimp/assimp/issues/5684
2024-07-23 16:32:11 +02:00
JensEhrhardt-eOPUS
c55158cd82
CalcTangents: zero vector is invalid for tangent/bitangent ( #5432 )
...
* CalcTangents: zero vector is invalid for tangent/bitangent
2024-07-23 13:13:12 +02:00
Stepan Hrbek
206839d4f2
Allow empty slots in mTextureCoords ( #5636 )
...
* Allow empty slots in aiMesh::mTextureCoords.
1.Explicitly say in documentation that empty slots are allowed (it was unclear).
2.Change GetNumUVChannels() implementation to allow empty slots.
3.Revert fraction of 2da2835b29
where empty slots are detected and error logged.
* Fix #5632 by reverting fraction of d6aacefa1e
where Collada texcoords are renumbered to avoid empty slots.
---------
Co-authored-by: Kim Kulling <kimkulling@users.noreply.github.com>
2024-07-10 09:01:53 +02:00
Matthias Möller
35976a4eb4
fixes some uninit bool loads ( #5644 )
...
This commit fixes some bool loads which are not initialized. With ubsan and the "option -fsanitize=bool", this results in a runtime error during test execution.
Co-authored-by: Kim Kulling <kimkulling@users.noreply.github.com>
2024-07-02 21:54:18 +02:00
Kim Kulling
a51500ba2b
Draft: Update init of aiString ( #5623 )
...
* Draft: Update init of aiString
- closes https://github.com/assimp/assimp/issues/5622
* Update types.h
* Fix typo
* Fix another typo
* Adapt usage of AI_MAXLEN
* Fix compare operator
* Add missing renames
2024-06-17 13:12:54 +02:00
Kim Kulling
43634b8b27
Postprocessing: Fix endless loop ( #5605 )
...
- closes https://github.com/assimp/assimp/issues/5603
2024-05-31 09:36:14 +02:00
Johannes Unterguggenberger
47ef79672e
Reverts the changes introduced by commit ad766cb
in February 2022. ( #5542 )
...
* Reverts the changes introduced by commit ad766cb
in February 2022.
Explanation why the old code was just fine is given in Q&A #5512 .
* Added that missing ;
---------
Co-authored-by: Kim Kulling <kimkulling@users.noreply.github.com>
2024-04-29 21:03:57 +02:00
Succ3s
7bda0f88ca
SplitByBoneCount had a minor typo that prevented updates to nodes indices ( #5550 )
2024-04-23 21:40:06 +02:00
Kim Kulling
85f084a4ce
Update ComputeUVMappingProcess.cpp ( #5541 )
...
* Update ComputeUVMappingProcess.cpp
- closes https://github.com/assimp/assimp/issues/5540
* Update ComputeUVMappingProcess.cpp
Add missing token.
2024-04-11 11:30:36 +01:00
Stephen Gold
08c1adc015
fix issue #5461 (segfault after removing redundant materials) ( #5467 )
...
* fix issue #5641 (segfault after removing redundant materials)
* Update RemoveRedundantMaterials.cpp
- Fix 2 possible memleaks.
---------
Co-authored-by: Kim Kulling <kimkulling@users.noreply.github.com>
2024-04-10 00:22:57 +02:00
Laura Hermanns
727774f181
Fix compilation for MSVC14. ( #5490 )
...
- std::min/max were not defined in StackAllocator.inl; Also added explicit template arguments to break macro expansion if Windows.h is included prior and NOMINMAX macro is not present.
- Made static_assert statements compatible with C++11 in ProcessHelper.cpp.
- Removed unused string_view include in ObjFileParser.cpp.
2024-03-11 09:09:23 +01:00
Kim Kulling
01231d0e60
Add 2024 to copyright infos ( #5475 )
2024-02-23 22:30:05 +01:00
Kim Kulling
3990ec80a1
Kimkulling/fix bahavior of remove redundat mats issue 5438 ( #5451 )
...
* Fix crash in viewer
* Fix bevavior when material was not referenced
2024-02-01 21:27:04 +01:00
Kim Kulling
c08e3b4abb
Add bounds checks to the parsing utilities. ( #5421 )
...
* Add bounds checks to the parsing utilities.
* Fix merge conflicts in ACLoader.
* Fix loaders
* Fix unittest of AC-Loader.
* Remove dead code.
* Md5Parser fixes
* Fix md5-parsing
* Fix Merge conflict
* Fix merge conflicts.
* Md5: Fix warning: missing return statement.
2024-01-30 14:32:41 +01:00
Kim Kulling
25aee03f66
Fix: Add missing transformation for normalized normals.
2023-10-29 10:05:25 +01:00
Kim Kulling
2a347014f3
Update ImproveCacheLocality.cpp
2023-10-08 18:35:08 +00:00
Kim Kulling
a531c72f7f
Update ImproveCacheLocality.cpp
...
- closes https://github.com/assimp/assimp/issues/5262
2023-10-08 18:35:08 +00:00
Kim Kulling
5b8cfa920b
Replace an assert by a error log.
2023-10-02 11:31:18 +02:00
ockeymm
7b6bf139cf
include memory.h to fix compile error
2023-10-01 16:11:20 +02:00
ockeymm
b2bfe6d253
Use unique_ptr to release old vertices data.
2023-10-01 16:11:20 +02:00
ockeymm
7a4d8ec412
Reduce memory consumption in JoinVerticesProcess::ProcessMesh() significantly
2023-10-01 16:11:20 +02:00
Kim Kulling
59b1234496
Update GenVertexNormalsProcess.cpp ( #5228 )
...
- closes https://github.com/assimp/assimp/issues/5074
2023-09-14 00:37:13 +02:00
Aaron
0bfc588c39
Update Triangulate Process [more another case]
2023-08-15 18:01:16 +08:00
Alex
5bb1c6debd
Fix UNKNOWN READ crash in UpdateMeshReferences
2023-06-14 07:40:36 +02:00
Kristjan Skutta
cb86029153
Fixed missing config property lookup for removal of empty bones.
2023-06-06 14:30:35 +02:00
Kim Kulling
8cbfb44e9c
Remove dead code
2023-05-04 21:10:51 +02:00
Kim Kulling
1243325f10
Merge branch 'master' into kimkulling/refactoring_geoutils
2023-05-04 21:10:00 +02:00
Kim Kulling
75d024c91b
Reafctoring: Add GeoUtils usage
2023-05-04 20:57:20 +02:00
Kim Kulling
d58201a579
Refactoring: Reuse code from GeometryUtils
2023-05-04 00:00:52 +02:00
Suhajda Tamás
71043ec164
Add missing cast
2023-04-28 11:44:29 +02:00
Jackie9527
01488046e6
Fix warning related to unreachable-code-break.
...
Signed-off-by: Jackie9527 <80555200+Jackie9527@users.noreply.github.com>
2023-04-19 22:18:34 +08:00
Kim Kulling
5d841ec9a5
Refactoring: Cleanup post-processing steps.
2023-04-16 18:20:14 +02:00
Suhajda Tamás
23a3e8cf2d
ConvertToLHProcess noew inverts viewing direction
2023-04-04 19:39:32 +02:00
Suhajda Tamás
9d76493ad8
Fix mLookAt with pretransformed vertices
...
mLookAt is a position vector inside the nodes reference frame, not a direction vector, so translation should be applied to it.
2023-04-04 00:06:09 +02:00
Turo Lamminen
ea3cc37890
Check node parents in ValidateDataStructure
2023-03-21 11:36:49 +02:00
Kim Kulling
7e5a178637
Update: Add missing geo doc.
2023-03-14 23:49:41 +01:00
Kim Kulling
c537bd78d0
Refactoring: Code cleanup post-processing.
2023-03-14 23:39:36 +01:00
Kim Kulling
59d9711928
Refactoring: Code cleanup post-processing.
2023-03-14 23:37:10 +01:00
Kim Kulling
45c1da26b3
Refactoring: Code cleanup post-processing.
2023-03-14 23:34:31 +01:00
Kim Kulling
31ae9cde1c
Refactoring: Code cleanup post-processing.
2023-03-14 23:32:03 +01:00
Kim Kulling
1147f0c8bd
Refactoring: Code cleanup post-processing.
2023-03-14 21:04:43 +01:00
Kim Kulling
2acfc125c3
Refactoring: Make GeoUtils reusable
2023-03-14 20:03:14 +01:00
Jackie9527
f7f54036f2
bugfix the three vertices are collinear when converting a polygon to a triangle.
...
Signed-off-by: Jackie9527 <80555200+Jackie9527@users.noreply.github.com>
2023-03-01 14:26:04 +08:00
Kim Kulling
3585dd577d
Fix: Add default parameter to constructor/destructor.
2023-02-16 11:19:23 +01:00
Kim Kulling
7877dab43a
Fix: Fix typo
2023-02-16 10:59:36 +01:00
Kim Kulling
bc8a122d88
Review finding: Use constexpr instead of macro
2023-02-16 09:28:35 +01:00
sunjc
fb146b7d39
fix typo, use a macro to avoid magic numbers.
2023-02-08 10:13:48 +08:00
sunjc
647f1e47fa
fix regression in join vertices post process.
2023-02-07 20:05:39 +08:00
Kim Kulling
d6b8d61066
Merge branch 'master' into JoinVerticesProcessUsedVerticesMask
2023-01-30 20:58:21 +01:00