Garux
dd10fb6ee4
remove ASE parsing break added in c1968823ad
: original intent was to keep parsing ( #5634 )
...
crash case (iMaterialCount = 0) is handled by 47dbabadcd
2024-06-24 21:23:59 +02:00
Stepan Hrbek
adff2f388a
Fix collada uv channels - temporary was stored and then updated. So all information on uv channels was ignored. ( #5630 )
...
Co-authored-by: Kim Kulling <kimkulling@users.noreply.github.com>
2024-06-21 13:49:19 +02:00
ycn2022
0afd366dcb
Update FBXMeshGeometry.cpp ( #5624 )
...
Some FBXs do not have "Materials" information, which can cause parsing errors
Co-authored-by: Kim Kulling <kimkulling@users.noreply.github.com>
2024-06-20 21:26:04 +02:00
michaelsctts
77f7706a97
fix PLY binary export color from float to uchar ( #5608 )
2024-06-19 15:45:15 +02:00
Kim Kulling
5c2a33f230
Make stepfile schema validation more robust. ( #5627 )
...
* Make stepfile schema validation more robust.
* Update STEPFile.h
2024-06-18 14:22:12 +02:00
Kim Kulling
a51500ba2b
Draft: Update init of aiString ( #5623 )
...
* Draft: Update init of aiString
- closes https://github.com/assimp/assimp/issues/5622
* Update types.h
* Fix typo
* Fix another typo
* Adapt usage of AI_MAXLEN
* Fix compare operator
* Add missing renames
2024-06-17 13:12:54 +02:00
Kim Kulling
81858f9e62
Update MDLMaterialLoader.cpp ( #5620 )
...
* Update MDLMaterialLoader.cpp
- closes https://github.com/assimp/assimp/issues/5239
* Add missing declaration
2024-06-14 12:51:47 +02:00
Kim Kulling
97cbecb859
Move revision.h and revision.h.in to include folder ( #5615 )
2024-06-12 21:01:03 +02:00
Kim Kulling
a722e33027
Move aiScene constructor ( #5614 )
2024-06-11 21:19:52 +02:00
Kim Kulling
75a10fedd0
Replace duplicated trim ( #5613 )
2024-06-11 16:30:49 +02:00
Kim Kulling
43634b8b27
Postprocessing: Fix endless loop ( #5605 )
...
- closes https://github.com/assimp/assimp/issues/5603
2024-05-31 09:36:14 +02:00
Daniel Simon
329fee2f0b
Disabled maybe-uninitialized error for AssetLib/Obj/ObjFileParser.cpp as it seems to be spurious. Also fixed error message for previous GCC build issue modification ( #5593 )
...
Co-authored-by: Kim Kulling <kimkulling@users.noreply.github.com>
2024-05-26 21:07:13 +02:00
Kim Kulling
4584719362
Update ObjFileParser.cpp ( #5598 )
...
Ensure not checking empty strings
2024-05-26 18:39:14 +02:00
Kim Kulling
30466aaf16
Fix possible nullptr dereferencing. ( #5595 )
2024-05-24 15:36:30 +02:00
vengine
ec5242a1a0
Fix a bug that could cause assertion failure. ( #5575 )
...
Co-authored-by: macmini <xhnsworks2@icloud.com>
Co-authored-by: Kim Kulling <kimkulling@users.noreply.github.com>
2024-05-22 21:20:22 +02:00
Daniel Simon
6fa4f0ff5e
Temporary fix for GCC 13+ build issue -Warray-bounds ( #5577 )
...
Added cmake code to remove warnings for array-bounds and stringop-overflow specifically for MDLLoader.cpp on GCC 13 and above.
Co-authored-by: Kim Kulling <kimkulling@users.noreply.github.com>
2024-05-19 18:51:02 +02:00
Kim Kulling
942518a4ff
Remove deprecated c++11 warnings ( #5576 )
2024-05-15 10:22:03 +02:00
Julian Uy
b6d53a0047
glTF2Importer: Support .vrm extension ( #5569 )
...
Co-authored-by: Kim Kulling <kimkulling@users.noreply.github.com>
2024-05-13 13:24:41 +02:00
Kim Kulling
325b0a543f
Add checks for invalid buffer ans size ( #5570 )
2024-05-13 08:55:10 +02:00
Garux
47dbabadcd
fix ASE loader crash when *MATERIAL_COUNT or *NUMSUBMTLS is not specified or is 0 ( #5559 )
...
code was doing vector[0u - 1] dereference in this case
Co-authored-by: Kim Kulling <kimkulling@users.noreply.github.com>
2024-05-08 10:43:43 +02:00
Kim Kulling
c953739487
Kimkulling/fix pyassimp compatibility ( #5563 )
...
* Use correct exception message access
* Add missing docs
2024-05-06 21:38:29 +02:00
陈瑞锋
4621676424
fix a collada import bug ( #5561 )
2024-05-02 15:32:12 +02:00
Johannes Unterguggenberger
47ef79672e
Reverts the changes introduced by commit ad766cb
in February 2022. ( #5542 )
...
* Reverts the changes introduced by commit ad766cb
in February 2022.
Explanation why the old code was just fine is given in Q&A #5512 .
* Added that missing ;
---------
Co-authored-by: Kim Kulling <kimkulling@users.noreply.github.com>
2024-04-29 21:03:57 +02:00
Kim Kulling
c05895f3c7
Q3DLoader: Fix possible material string overflow ( #5556 )
...
- closes https://github.com/assimp/assimp/issues/5555
2024-04-26 11:11:19 +02:00
Succ3s
7bda0f88ca
SplitByBoneCount had a minor typo that prevented updates to nodes indices ( #5550 )
2024-04-23 21:40:06 +02:00
Zeun
b71b8f77ee
add some ASSIMP_INSTALL checks ( #5545 )
2024-04-16 23:41:21 +02:00
Kim Kulling
85f084a4ce
Update ComputeUVMappingProcess.cpp ( #5541 )
...
* Update ComputeUVMappingProcess.cpp
- closes https://github.com/assimp/assimp/issues/5540
* Update ComputeUVMappingProcess.cpp
Add missing token.
2024-04-11 11:30:36 +01:00
Stephen Gold
08c1adc015
fix issue #5461 (segfault after removing redundant materials) ( #5467 )
...
* fix issue #5641 (segfault after removing redundant materials)
* Update RemoveRedundantMaterials.cpp
- Fix 2 possible memleaks.
---------
Co-authored-by: Kim Kulling <kimkulling@users.noreply.github.com>
2024-04-10 00:22:57 +02:00
Alex Rønne Petersen
b8aa68a080
CMake: Allow linking draco statically if ASSIMP_BUILD_DRACO_STATIC is set. ( #5535 )
...
* CMake: Mark draco as a private dependency since assimp does not publicly expose its interface.
* CMake: Allow linking draco statically if ASSIMP_BUILD_DRACO_STATIC is set.
2024-04-08 23:28:37 +02:00
Kim Kulling
8b9ed34eaa
Update CMakeLists.txt ( #5531 )
...
* Update CMakeLists.txt
* Update Version.cpp
* Update CMakeLists.txt
Update minimum version of cmake
* Update utVersion.cpp
Adapt unittest
2024-04-07 23:14:12 +02:00
Kim Kulling
b41ffa5561
Remove default destructor definitions from cpp files ( #5528 )
2024-04-07 21:42:52 +02:00
Alejandro González
790aad4b62
Add macOS support to C4D importer ( #5516 )
...
The latest Cineware SDK explicitly asserts macOS support in its
documentation, but Assimp's C4D importer only works with Windows MSVC
targets. Let's improve its portability by refactoring importer code to
not depend on MSVC-only data types and quirks, and add support for linking
against the universal macOS static libraries provided in the Cineware
SDK.
Note that the C4D importer still cannot support Linux platforms because
Maxon does not provide the necessary precompiled Cineware libraries for
that platform. Windows MinGW targets are also out of the question as the
MinGW toolchain uses compiled libraries in a different format.
Co-authored-by: Kim Kulling <kimkulling@users.noreply.github.com>
2024-04-07 00:25:46 +02:00
RoboSchmied
52c2b6896a
Fix 16 typos ( #5518 )
...
Signed-off-by: RoboSchmied <github@roboschmie.de>
Co-authored-by: Kim Kulling <kimkulling@users.noreply.github.com>
2024-04-06 21:26:32 +02:00
Julian Knodt
39ce0c0456
Respect merge identical vertices in ObjExporter ( #5521 )
...
Co-authored-by: Kim Kulling <kimkulling@users.noreply.github.com>
2024-04-02 18:31:19 +02:00
Kristjan Skutta
feb861f17b
Fix duplicate degrees to radians conversion in fbx importer. ( #5427 )
...
Co-authored-by: Kim Kulling <kimkulling@users.noreply.github.com>
2024-03-22 00:01:57 +01:00
Kim Kulling
fcb1444b84
Add correction of fbx model rotation ( #5494 )
2024-03-17 17:46:28 +01:00
Laura Hermanns
727774f181
Fix compilation for MSVC14. ( #5490 )
...
- std::min/max were not defined in StackAllocator.inl; Also added explicit template arguments to break macro expansion if Windows.h is included prior and NOMINMAX macro is not present.
- Made static_assert statements compatible with C++11 in ProcessHelper.cpp.
- Removed unused string_view include in ObjFileParser.cpp.
2024-03-11 09:09:23 +01:00
sSsA01
f95050e7aa
Append a setting "AI_CONFIG_EXPORT_FBX_TRANSPARENCY_FACTOR_REFER_TO_OPACITY". ( #5450 )
...
Co-authored-by: Kim Kulling <kimkulling@users.noreply.github.com>
2024-02-27 20:26:13 +01:00
Kim Kulling
01231d0e60
Add 2024 to copyright infos ( #5475 )
2024-02-23 22:30:05 +01:00
Kim Kulling
4d6dd80257
Add correct double zero check ( #5471 )
...
* Add correct double zero check
* Use std::fpclassify
2024-02-22 13:58:25 +01:00
Adam Mizerski
4b9f46dbda
ColladaParser: check values length ( #5462 )
...
* ColladaParser: check values length
fixes : #4286
* Refactor calculation of size for data
---------
Co-authored-by: Kim Kulling <kimkulling@users.noreply.github.com>
2024-02-15 13:07:00 +01:00
fvbj
2d98f6a880
Fix identity matrix check ( #5445 )
...
* Fix identity matrix check
Adds an extra epsilon value to check the matrix4x4 identity. The method is also used to export to GLTF/GLTF2 format to check node transformation matrices. The epsilon value can be set using AI_CONFIG_CHECK_IDENTITY_MATRIX_EPSILON with the default value set to 10e-3f for backward compatibility of legacy code.
* Fix type of float values in the unit test
* Update matrix4x4.inl
Fix typo
* Update matrix4x4.inl
Remove dead code.
* Add isIdentity-Test
* Update AssimpAPITest_aiMatrix4x4.cpp
---------
Co-authored-by: Kim Kulling <kimkulling@users.noreply.github.com>
2024-02-06 21:24:41 +01:00
Julian Knodt
c877a15140
`Blendshape`->`Geometry` in FBX Export ( #5419 )
...
When loading a mesh exported from assimp into Blender, it warns that it has an incorrect class.
While debugging, I traced it back to this being `Blendshape` where `Geometry` was expected. This
is likely because this node describes a `Geometry`, which is used as a blendshape. I'm not sure
if any other DCC tools or places to import it expect `Blendshape` instead (i.e. was this code
ever tested?), but it fixes its use in Blender.
Co-authored-by: Kim Kulling <kimkulling@users.noreply.github.com>
2024-02-05 16:55:00 +01:00
Florian Born
f59a5fab1a
More GLTF loading hardening ( #5415 )
...
Co-authored-by: Kim Kulling <kimkulling@users.noreply.github.com>
2024-02-04 21:23:31 +01:00
Galen Xiao
b7b6601a75
feat:1.add 3mf vertex color read 2.fix 3mf read texture bug ( #5361 )
...
* feat:1.add 3mf vertex color read 2.fix 3mf read texture bug
* fix checks failed
* Trigger CI
---------
Co-authored-by: Kim Kulling <kimkulling@users.noreply.github.com>
2024-02-04 20:23:07 +01:00
Steve M
005399a671
Fix X importer breakage introduced in commit f844c33
( #5372 )
...
* Update XFileImporter.cpp
Comment out boneIdx conditional which caused massive breakage
* Update XFileImporter.cpp
Fix typo
* Update XFileImporter.cpp
Dummy whitespace change to attempt to re-trigger failing CI tests
---------
Co-authored-by: Steve M <praktique-tellypresence@yahoo.com>
Co-authored-by: Kim Kulling <kimkulling@users.noreply.github.com>
2024-02-04 10:38:07 +01:00
Kim Kulling
3990ec80a1
Kimkulling/fix bahavior of remove redundat mats issue 5438 ( #5451 )
...
* Fix crash in viewer
* Fix bevavior when material was not referenced
2024-02-01 21:27:04 +01:00
Kim Kulling
3476c79801
Static code analysis fixes ( #5447 )
...
* Static code analysis fixes
- Fix warning in LOW
* Fix possible out of bound access.
* Add default to class declaration
2024-01-31 09:30:54 +01:00
Kim Kulling
c08e3b4abb
Add bounds checks to the parsing utilities. ( #5421 )
...
* Add bounds checks to the parsing utilities.
* Fix merge conflicts in ACLoader.
* Fix loaders
* Fix unittest of AC-Loader.
* Remove dead code.
* Md5Parser fixes
* Fix md5-parsing
* Fix Merge conflict
* Fix merge conflicts.
* Md5: Fix warning: missing return statement.
2024-01-30 14:32:41 +01:00
tigertang
a02085ea98
Update StbCommon.h to stay up-to-date with stb_image.h.
...
This enables C++ API users to statically link Assimp into their projects along with stb_image.
2024-01-29 13:52:54 +01:00
Kim Kulling
a8d30f7e91
Update DXFLoader.cpp
...
revert it
2024-01-27 12:14:35 +01:00
Kim Kulling
c6fe03f7a5
Update DXFLoader.cpp
...
- Use constexpr instead of const.
2024-01-27 12:14:35 +01:00
seanth
8cde65bfe8
Updated AIC table
...
The previous table was in an incorrect order, leading to index references in DXF producing the wrong colours when converted.
Also added other entries to bring the total number of ACI colours up to the number that can be used in DXF files
2024-01-27 12:14:35 +01:00
seanth
240fa97fed
Update DXFLoader.cpp
...
Changed order of operations for insert positioning and scaling. Need to position the inserts before scaling it, otherwise the position ends up up being position*scale
2024-01-27 12:14:35 +01:00
seanth
727001b0ca
Update DXFLoader.cpp
...
Edited out line suspected to be causing changes in position when changes in scale are made to inserted BLOCKS
2024-01-27 12:14:35 +01:00
julianknodt
bdc08dd4a9
Encode full weight as double
2024-01-27 10:10:28 +01:00
Robert Reif
81c20a5c61
Improve acc file loading
...
Add warning and support for tolerating a common problem where objects have wrong kid count.
Add support for empty texture layers.
2024-01-09 21:13:13 +01:00
Andre Schulz
9d71a275c3
X3D: Don't convert IndexedLineSet polylines with > 2 indices to triangles/polygons
...
Currently, when the coordIndex attribute of an IndexedLineSet contains a
polyline with > 2 indices, X3DGeoHelper::coordIdx_str2faces_arr() will
incorrectly determine the primitive type to be aiPrimitiveType_TRIANGLE or
aiPrimitiveType_POLYGON instead of aiPrimitiveType_LINE.
To fix this, this commit adds functions to explicitly handle an IndexedLineSet.
Fixes #3101
2024-01-09 20:55:51 +01:00
copycd
b571501559
@ error
...
Cause a TypeError when arg is UNSET
2024-01-06 20:57:41 +01:00
tangxin
9776d47cca
fix: KHR_materials_pbrSpecularGlossiness/diffuseFactor convert to pbrMetallicRoughness/baseColorFactor
2024-01-05 21:49:21 +01:00
Kim Kulling
636fbd65b3
Refactorings: come code cleanups
2023-12-29 16:55:37 +01:00
Kim Kulling
263bebb5ba
Add a test before generating the txture folder
2023-12-29 16:55:37 +01:00
Kim Kulling
5d5496f1ad
Update MDLMaterialLoader.cpp
2023-12-22 13:23:08 +01:00
Kim Kulling
69dae9599a
Fix integer overflow
...
- closes https://github.com/assimp/assimp/issues/4930
2023-12-22 13:23:08 +01:00
Kim Kulling
9dddef9b9d
Update D3MFImporter.cpp
2023-12-22 10:49:54 +01:00
Kim Kulling
b9576e6992
Update D3MFImporter.cpp
2023-12-22 10:49:54 +01:00
Kim Kulling
274f64cbf1
Check validity of archive without parsing
...
- closes https://github.com/assimp/assimp/issues/5392
2023-12-22 10:49:54 +01:00
Kim Kulling
7b54b0f406
Fix leak
...
- closes https://github.com/assimp/assimp/issues/5390
2023-12-21 21:18:38 +01:00
Marka Ragnos
3ce8a58d41
Update DefaultIOSystem.cpp
...
Added missing whitespace
2023-12-20 20:55:04 +01:00
Alexander Wagner
d03ab3ef27
- fixed Exist function on Linux
2023-12-20 20:55:04 +01:00
Alexander Wagner
e86f1acb9b
- fixed q3bsp issue
2023-12-20 20:55:04 +01:00
Alexey Medvedev
762ad8e9b7
glTF KHR_materials_specular fixes
2023-12-11 11:09:18 +01:00
Alexey Medvedev
dc399f7343
glTF KHR_materials_specular fixes
2023-12-11 11:09:18 +01:00
Alexey Medvedev
a72289b327
glTF KHR_materials_specular fixes
2023-12-11 11:09:18 +01:00
Stephen Gold
213d73ebc6
correct grammar/typographic errors in comments (8 files)
2023-12-04 23:58:54 +01:00
Futuremappermydud
a0b3df6dbd
Fix target names not being imported on some gLTF2 models
2023-12-04 21:11:55 +01:00
Stephen Gold
769e82ce5e
FBXMeshGeometry: solve issue #5116 using patch provided by darktjm
2023-12-04 20:57:10 +01:00
Maksim Kostin
d311fa95c6
Fix double free in Video::~Video()
2023-12-01 11:14:22 +01:00
Maksim Kostin
f701d702e4
Fix buffer overflow in FBX::Util::DecodeBase64()
2023-11-29 11:12:39 +01:00
IOhannes m zmölnig
6f715edfa0
Drop disabled zlib.h inclusion stubs
2023-11-29 09:53:03 +01:00
IOhannes m zmölnig
bfdd154d14
Always include "zlib.h" (rather than .../contrib/zlib/zlib.h)
...
The path to the vendored zlib is set by the build-system,
so there's no need to add additional preprocessor magic
2023-11-29 09:53:03 +01:00
IOhannes m zmölnig
6f70e220e4
always include "utf8.h" (instead of contrib/.../utf8.h)
2023-11-29 09:53:03 +01:00
Kim Kulling
85f64c9131
Use correct time scaling
2023-11-28 21:10:18 +01:00
Kim Kulling
01f2549abe
Fix the build
2023-11-28 20:49:10 +01:00
Kim Kulling
384db8686e
Update FBXConverter.cpp
...
- Temporary fix bind pose storage in offset matrix
- Will close https://github.com/assimp/assimp/issues/5132
2023-11-28 20:49:10 +01:00
Kim Kulling
77a8f019e3
Fix: Check if index for mesh access is out of range
2023-11-22 10:14:26 +01:00
Alexandre Avenel
e4e2c63e0c
Fix heap-buffer overflow in PLY parser
2023-11-20 08:43:17 +01:00
Alexandre Avenel
aae93691b9
Fix container overflow in MMD parser
...
Using reserve, buffer size is not updated. Since data is directly inserted and not using push_pack,
this can lead to a container overflow.
2023-11-17 14:33:17 +01:00
Florian Born
6004290dde
Use the correct allocator for deleting objects in case of duplicate animation Ids
2023-11-16 10:02:16 +01:00
Wojciech Matyjewicz
069e19487c
Fix parsing <init_from> in <image>.
...
The regression was introduced in 21678df
.
2023-11-16 08:50:10 +01:00
Wojciech Matyjewicz
2235518b3c
Fix parsing <instance_image> in <sampler2D>.
...
The regression was introduced in 904f17f
.
Since all the cases are now fully handled at the child level,
visiting the whole subtree is changed into iteration over the children.
2023-11-16 08:50:10 +01:00
copycd
8648c2af45
fix mesh-name error.
2023-11-15 13:04:10 +01:00
Kim Kulling
f0e7448fdc
Remove double delete
2023-11-14 22:09:56 +01:00
julianknodt
9efbbe0a69
Read int from uvwsrc
...
Previously was reading a uint, which always failed. Since the output was never checked, this
seemed to work, and works fine for most models since they only use UV channel 0.
2023-11-14 16:31:56 +01:00
Kim Kulling
4535e37fc6
Fix namespaces.
2023-11-12 21:09:33 +01:00
Kim Kulling
8cf2d6e588
Refactoring: Some cleanups
2023-11-12 21:09:33 +01:00
Kim Kulling
aa3abb3c06
Fix warning: remove printf
2023-11-10 15:36:40 +01:00
Kim Kulling
0b0ec713f6
Fix empty mesh handling
2023-11-10 15:36:40 +01:00
julianknodt
28ab0a094a
Fix incorrect deg->radian conversion
...
It seems that rotation matrices later expect radians.
This conversion breaks it, and was validated on the conversion of
`cesium_man.glb` --> `cesium_man.fbx`
2023-11-07 20:06:16 +01:00
Tárcio Vinícius
46b19cc6a4
utf8 header not found
2023-11-06 16:09:53 +01:00