Alex
c3e69b5b82
Fix Heap-buffer-overflow READ in Assimp::ObjFileParser::getFace
2023-05-31 08:01:41 +00:00
Kim Kulling
466f6960ac
Merge branch 'gltf2_metadata_export' of https://github.com/C-Tech-Development-Corp/assimp into C-Tech-Development-Corp-gltf2_metadata_export
2023-05-30 08:14:49 +02:00
Kim Kulling
17c1a9125f
Merge branch 'master' into FixSkinnedWeightsAfterVertexRemappingOptimization
2023-05-24 23:36:59 +02:00
Kim Kulling
f43cfa1fba
Merge branch 'master' into msvc-clang-unused-function
2023-05-24 23:23:40 +02:00
Kim Kulling
ca848c5b09
Merge branch 'master' into fix-pbrt-exporter
2023-05-24 22:28:32 +02:00
Kim Kulling
d73595b85d
Merge branch 'master' into master
2023-05-24 21:35:26 +02:00
Samuel Kogler
0fbd2f5894
Merge branch 'master' into fix-pbrt-exporter
2023-05-24 15:24:46 +02:00
Kim Kulling
b7a8c4ba75
Update glTF2Asset.inl
2023-05-23 10:33:14 +02:00
Kim Kulling
e947471549
Merge branch 'master' into refactor/KHR_material_specular
2023-05-22 09:49:01 +02:00
Kim Kulling
03163a1dda
Merge branch 'master' into master
2023-05-21 18:26:56 +02:00
Kim Kulling
7e16d4046e
Merge branch 'master' into FixSkinnedWeightsAfterVertexRemappingOptimization
2023-05-21 18:14:29 +02:00
Kim Kulling
9c45f727e3
Update ASELoader.cpp
2023-05-20 14:27:57 +02:00
Kim Kulling
94905d445f
Revert usage of unique_ptr - error.
2023-05-15 16:06:02 +02:00
Kim Kulling
71a4977dd1
Fix: Try unique_ptr
2023-05-15 15:46:21 +02:00
Kim Kulling
8ad4bb0b2c
Update StackAllocator.inl
2023-05-15 15:09:54 +02:00
Kim Kulling
b5b6400320
Fix: Use vector.
2023-05-15 15:08:52 +02:00
Kim Kulling
aed43878ef
Merge branch 'master' into FlorianBorn71-SmallAllocationFixInFBXLoader
2023-05-15 14:28:46 +02:00
Kim Kulling
ad399adf4b
Add missing include
2023-05-15 13:19:02 +02:00
Kim Kulling
121f09b62a
Fix: Fix the build.
2023-05-15 11:02:58 +02:00
Kim Kulling
e627f691a8
Merge branch 'SmallAllocationFixInFBXLoader' of https://github.com/FlorianBorn71/assimp into FlorianBorn71-SmallAllocationFixInFBXLoader
2023-05-15 09:30:57 +02:00
Lutz Hören
9ea37b5330
copy aiMetadata objects in scene combiner
2023-05-11 08:00:25 +02:00
Kim Kulling
ade4514752
Merge branch 'master' into fix-pbrt-exporter
2023-05-10 21:55:00 +02:00
Florian Born
d825eb7cf0
Skinning weights i gltf were broken by PR#5003 (vertex remapping)
2023-05-08 20:04:38 +02:00
Mathieu Westphal
69145c8929
Fix librt link
2023-05-05 08:47:14 +02:00
Kim Kulling
8cbfb44e9c
Remove dead code
2023-05-04 21:10:51 +02:00
Kim Kulling
1243325f10
Merge branch 'master' into kimkulling/refactoring_geoutils
2023-05-04 21:10:00 +02:00
Kim Kulling
75d024c91b
Reafctoring: Add GeoUtils usage
2023-05-04 20:57:20 +02:00
Kim Kulling
167d811ff7
Doc: Add missing doc to GeometryUtils.
2023-05-04 00:04:56 +02:00
Kim Kulling
d58201a579
Refactoring: Reuse code from GeometryUtils
2023-05-04 00:00:52 +02:00
Jackie9527
fbf8799cb5
Fix warning related to unused-function.
...
Signed-off-by: Jackie9527 <80555200+Jackie9527@users.noreply.github.com>
2023-05-03 23:02:38 +08:00
Samuel Kogler
55cb19f924
Fix PBRT exporter coordinate system
...
Was just mirroring the x axis. This uses aiProcess_ConvertToLeftHanded and
rotates the root node to match PBRT.
The problem is apparent when using an environment map texture.
2023-05-03 16:52:33 +02:00
Samuel Kogler
f32c21e6b3
Fix PBRT exporter FoV aspect ratio calculation
2023-05-03 16:46:54 +02:00
Jackie9527
92d426de2b
Remove unused -Wno-missing-noreturn.
...
Signed-off-by: Jackie9527 <80555200+Jackie9527@users.noreply.github.com>
2023-04-29 01:05:25 +08:00
Jackie9527
51494e1b4f
Remove unused -Wno-deprecated-copy-with-user-provided-dtor.
...
Signed-off-by: Jackie9527 <80555200+Jackie9527@users.noreply.github.com>
2023-04-29 00:55:13 +08:00
Jackie9527
cdefc9f7aa
Remove unused -Wno-deprecated-copy-with-dtor.
...
Signed-off-by: Jackie9527 <80555200+Jackie9527@users.noreply.github.com>
2023-04-29 00:43:40 +08:00
Jackie9527
cabf3a5d17
Fix warning related to unreachable-code-return.
...
Signed-off-by: Jackie9527 <80555200+Jackie9527@users.noreply.github.com>
2023-04-29 00:30:21 +08:00
Jackie9527
a8e7c23605
Fix warning related to unreachable-code.
...
Signed-off-by: Jackie9527 <80555200+Jackie9527@users.noreply.github.com>
2023-04-29 00:29:33 +08:00
Suhajda Tamás
71043ec164
Add missing cast
2023-04-28 11:44:29 +02:00
Kim Kulling
230bee2e34
Merge branch 'master' into msvc-clang-missing-variable-declarations
2023-04-26 11:15:32 +02:00
Kim Kulling
07aae9eaee
Merge branch 'master' into msvc-clang-deprecated-copy-with-dtor
2023-04-26 10:42:51 +02:00
Kim Kulling
71366fff8e
Merge branch 'master' into msvc-clang-inconsistent-missing-destructor-override
2023-04-26 09:31:55 +02:00
Kim Kulling
965ebaf78b
Merge branch 'master' into deprecated-copy-with-user-provided-dtor
2023-04-26 08:22:51 +02:00
Kim Kulling
1ecb8e9196
Merge branch 'master' into msvc-clang-missing-noreturn
2023-04-25 23:56:39 +02:00
Jackie9527
ff17f1fe3d
Remove -Wno-missing-variable-declarations.
...
Signed-off-by: Jackie9527 <80555200+Jackie9527@users.noreply.github.com>
2023-04-19 23:29:03 +08:00
Jackie9527
46677b835c
Fix warning related to missing-variable-declarations, add static to global variable.
...
Signed-off-by: Jackie9527 <80555200+Jackie9527@users.noreply.github.com>
2023-04-19 23:28:36 +08:00
Jackie9527
5738b3d172
Fix warning related to missing-variable-declarations, add static to global variable.
...
Signed-off-by: Jackie9527 <80555200+Jackie9527@users.noreply.github.com>
2023-04-19 23:27:23 +08:00
Jackie9527
739cf15a1e
Fix warning related to missing-variable-declarations, remove unused global variables.
...
Signed-off-by: Jackie9527 <80555200+Jackie9527@users.noreply.github.com>
2023-04-19 23:26:03 +08:00
Jackie9527
c0947b704e
Fix warning related to missing-variable-declarations, remove unused global variables.
...
Signed-off-by: Jackie9527 <80555200+Jackie9527@users.noreply.github.com>
2023-04-19 23:24:40 +08:00
Jackie9527
1b826afeda
Remove -Wno-unreachable-code-break.
...
Signed-off-by: Jackie9527 <80555200+Jackie9527@users.noreply.github.com>
2023-04-19 22:26:44 +08:00
Jackie9527
4d962057e5
Fix warning related to unreachable-code-break.
...
Signed-off-by: Jackie9527 <80555200+Jackie9527@users.noreply.github.com>
2023-04-19 22:18:35 +08:00
Jackie9527
12bc34a45c
Fix warning related to unreachable-code-break.
...
Signed-off-by: Jackie9527 <80555200+Jackie9527@users.noreply.github.com>
2023-04-19 22:18:35 +08:00
Jackie9527
0a05a1f17f
Fix warning related to unreachable-code-break.
...
Signed-off-by: Jackie9527 <80555200+Jackie9527@users.noreply.github.com>
2023-04-19 22:18:34 +08:00
Jackie9527
cec41f6dd5
Fix warning related to unreachable-code-break.
...
Signed-off-by: Jackie9527 <80555200+Jackie9527@users.noreply.github.com>
2023-04-19 22:18:34 +08:00
Jackie9527
7620a69e3e
Fix warning related to unreachable-code-break.
...
Signed-off-by: Jackie9527 <80555200+Jackie9527@users.noreply.github.com>
2023-04-19 22:18:34 +08:00
Jackie9527
9e80dfc42d
Fix warning related to unreachable-code-break.
...
Signed-off-by: Jackie9527 <80555200+Jackie9527@users.noreply.github.com>
2023-04-19 22:18:34 +08:00
Jackie9527
01488046e6
Fix warning related to unreachable-code-break.
...
Signed-off-by: Jackie9527 <80555200+Jackie9527@users.noreply.github.com>
2023-04-19 22:18:34 +08:00
Kim Kulling
9e056218cf
Merge branch 'master' into msvc-clang-unreachable-code-return
2023-04-17 22:04:07 +02:00
Kim Kulling
ca937788ee
Fix: Fix leak in Scope class, FBX
...
- closes https://github.com/assimp/assimp/issues/3421
2023-04-17 20:08:58 +02:00
Kim Kulling
aee4df9be8
Fix possible dereferencing of invalid pointer.
...
- closes https://github.com/assimp/assimp/issues/4918
2023-04-17 15:40:29 +02:00
Kim Kulling
5d841ec9a5
Refactoring: Cleanup post-processing steps.
2023-04-16 18:20:14 +02:00
Adam Beili
e193220ad8
Merge branch 'master' into refactor/KHR_material_specular
2023-04-06 02:42:18 +02:00
Suhajda Tamás
3dd08cdd60
Added note
2023-04-05 13:01:38 +02:00
Suhajda Tamás
74509ef8bd
Revert "FBXConverter : import FbxCamera correctly"
...
This reverts commit cdfdd75a66
.
2023-04-05 12:19:39 +02:00
Jackie9527
d4c21ba9a8
Fix warning related to error=return-type.
...
/home/runner/work/assimp/assimp/code/AssetLib/Ogre/OgreXmlSerializer.cpp: In member function ‘T Assimp::Ogre::OgreXmlSerializer::ReadAttribute(Assimp::XmlNode&, const char*) const [with T = bool]’:
Error: /home/runner/work/assimp/assimp/code/AssetLib/Ogre/OgreXmlSerializer.cpp:131:1: error: control reaches end of non-void function [-Werror=return-type]
Signed-off-by: Jackie9527 <80555200+Jackie9527@users.noreply.github.com>
2023-04-05 07:39:17 +08:00
Jackie9527
116ceeca31
Remove -Wno-unreachable-code-return.
...
Signed-off-by: Jackie9527 <80555200+Jackie9527@users.noreply.github.com>
2023-04-05 07:39:12 +08:00
Jackie9527
a7cb3b4dbb
Fix warning related to unreachable-code-return, remove redundant return.
...
Signed-off-by: Jackie9527 <80555200+Jackie9527@users.noreply.github.com>
2023-04-05 07:37:49 +08:00
Jackie9527
55c6eaee0c
Fix warning related to unreachable-code-return, remove redundant return.
...
Signed-off-by: Jackie9527 <80555200+Jackie9527@users.noreply.github.com>
2023-04-05 07:37:48 +08:00
Jackie9527
502bceb6e8
Fix warning related to unreachable-code-return, remove redundant return.
...
Signed-off-by: Jackie9527 <80555200+Jackie9527@users.noreply.github.com>
2023-04-05 07:37:48 +08:00
Jackie9527
a87585668d
Fix warning related to unreachable-code-return, disable warning.
...
Signed-off-by: Jackie9527 <80555200+Jackie9527@users.noreply.github.com>
2023-04-05 07:37:48 +08:00
Suhajda Tamás
23a3e8cf2d
ConvertToLHProcess noew inverts viewing direction
2023-04-04 19:39:32 +02:00
Kim Kulling
89ccc89298
Merge branch 'master' into fix_pretransform_vertices_with_cameras
2023-04-04 17:21:05 +02:00
Kim Kulling
1733d9f795
Merge branch 'master' into msvc-clang-unreachable-code
2023-04-04 17:02:22 +02:00
Kim Kulling
17bdd5f9b5
Merge branch 'master' into msvc-clang-format-non-iso
2023-04-04 15:59:27 +02:00
Kim Kulling
e6f26fc52e
Remove dead code.
2023-04-04 12:54:26 +02:00
Kim Kulling
ccbcf15a21
Merge branch 'master' into fix_getenv_uwp
2023-04-04 12:53:29 +02:00
Suhajda Tamás
9d76493ad8
Fix mLookAt with pretransformed vertices
...
mLookAt is a position vector inside the nodes reference frame, not a direction vector, so translation should be applied to it.
2023-04-04 00:06:09 +02:00
Kim Kulling
a259277498
Merge branch 'master' into master
2023-04-03 23:54:28 +02:00
Suhajda Tamás
9915e875bf
glTF2: Fix incorrect camera position
2023-04-03 23:35:04 +02:00
Kim Kulling
8aa959fa19
Merge branch 'master' into MemoryOptimizationForGLTFWithSharedAttr
2023-04-03 20:48:51 +02:00
Kim Kulling
d6885d4025
Merge branch 'master' into msvc-clang-nested-anon-types
2023-04-03 19:59:59 +02:00
Kim Kulling
19ff57a6c3
Merge branch 'master' into MemoryOptimizationForGLTFWithSharedAttr
2023-04-03 11:28:10 +02:00
Ani
ae121bfbb0
Merge branch 'master' into fix-loadfbxasserterror
2023-04-02 22:13:33 -07:00
liedtkeInTUM
97e31a895e
Merge branch 'master' into fix_getenv_uwp
2023-04-01 23:38:48 +02:00
Kim Kulling
9fba0ee31b
Merge branch 'master' into msvc-clang-deprecated-copy-with-dtor
2023-04-01 20:46:34 +02:00
Jackie9527
dacaebc078
Remove unused -Wno-shadow-field-in-constructor.
...
Signed-off-by: Jackie9527 <80555200+Jackie9527@users.noreply.github.com>
2023-04-01 23:49:22 +08:00
Jackie9527
bddb4559a1
Remove -Wno-deprecated-copy-with-dtor.
...
Signed-off-by: Jackie9527 <80555200+Jackie9527@users.noreply.github.com>
2023-04-01 22:46:01 +08:00
Jackie9527
7df4efea44
Fix warning related to inconsistent-missing-destructor-override.
...
Signed-off-by: Jackie9527 <80555200+Jackie9527@users.noreply.github.com>
2023-04-01 21:49:38 +08:00
Jackie9527
e36812a449
Remove unused -Wno-deprecated-copy-with-user-provided-dtor.
...
Signed-off-by: Jackie9527 <80555200+Jackie9527@users.noreply.github.com>
2023-04-01 19:07:13 +08:00
Jackie9527
87c309566f
Fix warning related to missing-noreturn.
...
Signed-off-by: Jackie9527 <80555200+Jackie9527@users.noreply.github.com>
2023-04-01 18:46:12 +08:00
Jackie9527
20b2f857c5
Remove -Wno-unreachable-code
...
Signed-off-by: Jackie9527 <80555200+Jackie9527@users.noreply.github.com>
2023-04-01 13:07:30 +08:00
Jackie9527
04066ece8e
Fix warning related to unreachable-code.
...
Signed-off-by: Jackie9527 <80555200+Jackie9527@users.noreply.github.com>
2023-04-01 13:02:04 +08:00
Jackie9527
1dcb5da1cd
Fix warning related to unreachable-code.
...
Signed-off-by: Jackie9527 <80555200+Jackie9527@users.noreply.github.com>
2023-04-01 13:01:22 +08:00
Jackie9527
94067994cc
Fix warning related to format-non-iso.
...
Signed-off-by: Jackie9527 <80555200+Jackie9527@users.noreply.github.com>
2023-04-01 12:29:42 +08:00
Jackie9527
6b54761310
Fix warning related to nested-anon-types.
...
Signed-off-by: Jackie9527 <80555200+Jackie9527@users.noreply.github.com>
2023-04-01 10:30:10 +08:00
Sven Liedtke
5cf9d3abf7
std::getenv is not supported using uwp
2023-04-01 01:02:21 +02:00
Kim Kulling
85b470a3ee
Merge branch 'master' into clang-cl-15.0.1-support
2023-03-29 21:20:25 +02:00
aniongithub
4438b3ecc9
Fix Issue #4486 using the fix described by @jianliang79
2023-03-29 18:36:18 +00:00
Adam Beili
8ac0af5c58
.
2023-03-26 17:13:16 +02:00
Adam Beili
b6ecba9114
fix
2023-03-26 17:03:46 +02:00
Adam Beili
83053f3d56
Made usePbrSpecGloss a exportproperty, fixed mat_specular to spec
2023-03-26 16:55:38 +02:00
Adam Beili
fa00571049
fixed compilation bug
2023-03-26 14:52:44 +02:00
Adam Beili
c9177b7811
Merge branch 'master' into refactor/KHR_material_specular
2023-03-24 21:47:19 +01:00
inhosens
7095c4f52f
Merge branch 'master' into master
2023-03-23 07:30:49 +01:00
Turo Lamminen
5ddd18d1c7
Add more AMF unit tests
2023-03-22 12:06:30 +02:00
inhosens
7cc0c06fdb
Merge branch 'assimp:master' into master
2023-03-22 08:30:52 +01:00
Kim Kulling
f81bb90f89
Merge branch 'master' into 1-1922
2023-03-21 12:58:11 +01:00
Turo Lamminen
ea3cc37890
Check node parents in ValidateDataStructure
2023-03-21 11:36:49 +02:00
Inho Lee
cdfdd75a66
FBXConverter : import FbxCamera correctly
...
FbxCamera's default value is correct but its transformed
values are described in each NodeProperties.
2023-03-21 10:35:24 +01:00
Kim Kulling
e7e4e3100f
Merge branch 'master' into 1-3193
2023-03-20 14:01:35 +01:00
Turo Lamminen
3a69e353f3
Make Blender MVert no field optional
2023-03-20 12:00:20 +02:00
Kim Kulling
e394bda707
Merge branch 'master' into 1-1922
2023-03-17 09:37:37 +01:00
Kim Kulling
b5f68d73ab
Merge branch 'master' into fix_hl1_mdl_importer_bone_hierarchy
2023-03-15 11:36:45 +01:00
Kim Kulling
7e5a178637
Update: Add missing geo doc.
2023-03-14 23:49:41 +01:00
Kim Kulling
c537bd78d0
Refactoring: Code cleanup post-processing.
2023-03-14 23:39:36 +01:00
Kim Kulling
59d9711928
Refactoring: Code cleanup post-processing.
2023-03-14 23:37:10 +01:00
Kim Kulling
45c1da26b3
Refactoring: Code cleanup post-processing.
2023-03-14 23:34:31 +01:00
Kim Kulling
31ae9cde1c
Refactoring: Code cleanup post-processing.
2023-03-14 23:32:03 +01:00
Kim Kulling
1147f0c8bd
Refactoring: Code cleanup post-processing.
2023-03-14 21:04:43 +01:00
Kim Kulling
2acfc125c3
Refactoring: Make GeoUtils reusable
2023-03-14 20:03:14 +01:00
Marc-Antoine Lortie
eb3b48e523
Invert logic in build_bone_children_hierarchy.
2023-03-14 09:21:45 -04:00
Marc-Antoine Lortie
4c015077b8
Add missing member initializer.
2023-03-13 19:07:14 -04:00
Marc-Antoine Lortie
054dacd068
Improved comments.
2023-03-13 19:07:14 -04:00
Marc-Antoine Lortie
4b4cb55f22
Fix HL1MDLLoader flattened bone hierarchy.
2023-03-13 19:06:18 -04:00
Kim Kulling
3840c8bd8d
Merge branch 'master' into 1-3458
2023-03-12 17:06:09 +01:00
Florian Born
8176c6a0e4
Adjusting the unit tests to pass new gltf
2023-03-10 18:36:43 +01:00
Florian Born
60cefdd549
Jan's fedback
2023-03-10 12:10:38 +01:00
Kim Kulling
ffd222334f
Fix: Remove buggy namespace declaration
2023-03-10 09:00:37 +01:00
Kim Kulling
2f7882cb8d
Update: Small code cleanup
2023-03-10 08:49:58 +01:00
Kim Kulling
63dae0a7f2
Fix: Add security asserts.
2023-03-10 08:48:11 +01:00
Kim Kulling
c82a6d05b0
Code cleanup
2023-03-10 08:43:12 +01:00
Florian Born
dfd70b5c10
GLTF Importer: Build a list of the actual vertices so it works well with shared attribute lists
2023-03-09 19:06:58 +01:00
Turo Lamminen
f3767a4eb2
Use unordered_map for subdivision process edge map
2023-03-09 14:33:43 +02:00
Kim Kulling
05249353d4
Merge branch 'master' into UseNewMetaDataTypesInFBXConverter
2023-03-08 10:53:00 +01:00
Florian Born
069b3ecdf8
After Kim's addition to meta data types, use it in the FBX converter
2023-03-07 17:44:48 +01:00
Kim Kulling
44c2785663
Make debug message more professional.
2023-03-07 17:01:08 +01:00
Urs Hanselmann
2efd48dee2
disable another debug print message
2023-03-04 14:53:48 +01:00
Jackie9527
424f53b4d6
bugfix remove duplicated data.
...
Signed-off-by: Jackie9527 <80555200+Jackie9527@users.noreply.github.com>
2023-03-04 16:25:56 +08:00
Jackie9527
a0c29202be
Add build options to fix issues with clang 15.
...
Signed-off-by: Jackie9527 <80555200+Jackie9527@users.noreply.github.com>
2023-03-02 21:12:35 +08:00
Jackie9527
f7f54036f2
bugfix the three vertices are collinear when converting a polygon to a triangle.
...
Signed-off-by: Jackie9527 <80555200+Jackie9527@users.noreply.github.com>
2023-03-01 14:26:04 +08:00
Jackie9527
437958ef91
bugfix fails to check if point in triangle.
...
Signed-off-by: Jackie9527 <80555200+Jackie9527@users.noreply.github.com>
2023-02-25 19:40:24 +08:00
Turo Lamminen
e8f0eb930d
Fix loading binary LWO files
2023-02-24 14:40:27 +02:00
Turo Lamminen
3bdc43a216
Add debug logging to LWO node graph generation
2023-02-24 14:40:27 +02:00
Turo Lamminen
657c1d8ad0
Use unique_ptr to store pivot nodes until moved to mapPivot
2023-02-24 14:40:23 +02:00
Turo Lamminen
3bdfecb0ed
Destroy mapPivot nodes as we go
2023-02-24 13:26:34 +02:00
Turo Lamminen
be28f0949b
Whitespace
2023-02-24 13:20:40 +02:00
Turo Lamminen
53c6cc0966
Add a scope so mapPivot is destroyed when no longer used
2023-02-24 13:19:38 +02:00
Turo Lamminen
92f7c50c91
Remove dead code
2023-02-24 13:18:04 +02:00
Turo Lamminen
28d4e394c0
Use std::unique_ptr a bit
2023-02-24 13:17:32 +02:00
Kim Kulling
eb73464055
Merge branch 'master' into fix-fbx-document-duplicate-id-leak
2023-02-23 10:39:52 +01:00
Kim Kulling
2c3d52a5a1
Merge branch 'master' into master
2023-02-23 10:15:07 +01:00
Kim Kulling
c8d50dc83f
Merge branch 'master' into patch-2
2023-02-22 21:33:20 +01:00
Johan Mattsson
fa4273ee1f
Fix index out of bounds
2023-02-20 19:56:57 +01:00
Johan Mattsson
f8132bf17c
Fix index out of bounds
2023-02-20 19:50:06 +01:00
Aaron Jacobs
53e5f19b14
Use C++ style casts
2023-02-17 11:20:00 -08:00
Aaron Jacobs
e4386d3013
Fix implicit conversion errors on macOS
2023-02-16 15:21:43 -08:00
Anton Vaneev
2cd3da4831
Fix a leak in FBXDocument when duplicate object IDs are found
...
When a duplicate ID is encountered, existing LazyObject is overwritten. Previously allocated instance leaks.
This change deletes the previously allocated instance before overwriting the pointer.
2023-02-16 11:21:29 +01:00
Kim Kulling
3585dd577d
Fix: Add default parameter to constructor/destructor.
2023-02-16 11:19:23 +01:00
Kim Kulling
7877dab43a
Fix: Fix typo
2023-02-16 10:59:36 +01:00
Kim Kulling
bc8a122d88
Review finding: Use constexpr instead of macro
2023-02-16 09:28:35 +01:00
Kim Kulling
b170370e5c
Fix: Fix memleak when exiting method by exception
2023-02-08 21:29:54 +01:00
sunjc
fb146b7d39
fix typo, use a macro to avoid magic numbers.
2023-02-08 10:13:48 +08:00
sunjc
647f1e47fa
fix regression in join vertices post process.
2023-02-07 20:05:39 +08:00
Kim Kulling
839cd35a54
Merge branch 'master' into master
2023-02-04 19:08:39 +01:00
Matthias Möller
db72c6ee38
When "getNextBlock" was called after "getNextLine", the pointer could still on the newline.
...
The pointer to a newline could not advance enough, when the line ended with \r\n. The resulting buffer was correct, as the buffer range went from <start> until \r, but that the pointer increased by just 1 could lead to the problem that the next pointer points at \n, which is still part of the newline and therefore, "getNextBlock" got 1 byte too much.
Refs Issue #4871
2023-02-04 15:16:22 +01:00
Robert Reif
88ef9eecc1
ACLoader: add support for reading more than one texture per object
2023-02-03 20:29:56 -05:00
Turo Lamminen
8d405d60d9
Fix Terragen loader
...
Fixes e8d2b84017
2023-02-03 11:44:27 +02:00
PencilAmazing
feb3e9ff7a
Merge branch 'master' into PLYcomments#4866
2023-02-01 13:05:55 -05:00
Kim Kulling
5caae1a86d
Merge branch 'master' into JoinVerticesProcessUsedVerticesMask
2023-01-31 21:03:32 +01:00
Kim Kulling
d6b8d61066
Merge branch 'master' into JoinVerticesProcessUsedVerticesMask
2023-01-30 20:58:21 +01:00
krishty
df28e7830f
Merge branch 'master' into fix-build-without-armaturepopulate-post-process
2023-01-29 01:14:33 +01:00
PencilAmazing
6dc12f57a2
Merge branch 'master' into PLYcomments#4866
2023-01-23 21:50:26 -05:00
Kim Kulling
57054415cf
Merge branch 'master' into fixLHNormals
2023-01-24 00:04:49 +01:00
PencilAmazing
4d733d80f1
Merge branch 'master' into PLYcomments#4866
2023-01-23 15:56:04 -05:00
Kim Kulling
b31c04e37c
Merge branch 'master' into fix-msvc-emplace-warnings
2023-01-23 21:37:41 +01:00
Kim Kulling
f830d7998e
Merge branch 'master' into clean-up-ctors-dtors
2023-01-23 21:21:34 +01:00
PencilAmazing
cb8320945d
Fix issue #4866 by continuing to resetting read loop after hitting a comment
2023-01-23 14:18:50 -05:00
Kim Kulling
036f2b3771
Merge branch 'master' into remove-stray-semicolon
2023-01-23 20:06:43 +01:00
Kim Kulling
3e20502e0f
Merge branch 'master' into fix_gltf2_camera_fov
2023-01-23 19:14:42 +01:00
Kim Kulling
3bd2f788f6
Merge branch 'master' into replace-variables-with-literals
2023-01-23 18:55:20 +01:00
AdamCichocki
5ed09b7ab6
usedVertexIndicesMask is now based on vector<boo> instead of vector<uint>
2023-01-23 16:39:06 +01:00
AdamCichocki
72b178b9fc
Optimized usedVertexIndices by using bitmask instead of unordered_set
2023-01-23 14:51:02 +01:00
Kim Kulling
f2f967b8ba
Merge branch 'master' into remove-useless-virtual
2023-01-22 20:25:45 +01:00
Kim Kulling
f8bc8293ce
Update FBXMeshGeometry.h
2023-01-22 16:48:45 +01:00
Kim Kulling
303c30668f
Merge branch 'master' into trim-whitespace
2023-01-22 16:37:43 +01:00
Kim Kulling
5ed01bcfa3
Ensure initializer exists
...
- Fixing a Codaxy finding.
2023-01-20 20:00:36 +01:00
Kim Kulling
81cf1369db
Set correct number of bones in mesh instance
2023-01-20 19:20:06 +01:00
Kim Kulling
ab0a119626
Update LimitBoneWeightsProcess.cpp
...
- Removing empty bones only if AI_CONFIG_IMPORT_REMOVE_EMPTY_BONES is enabled.
- closes https://github.com/assimp/assimp/issues/4840
2023-01-20 19:14:04 +01:00
lsnoel
8d1256f472
Comments about winding order fix for gen normals
2023-01-20 14:55:06 +00:00
Kim Kulling
d331a7e5d4
Merge branch 'master' into fix-build-without-armaturepopulate-post-process
2023-01-20 13:52:13 +01:00
lsnoel
eb5d3c51e8
Correctly consider aiProcess_FlipWindingOrder AND aiProcess_MakeLeftHanded when generating normals
2023-01-19 16:46:29 +00:00
Krishty
72f360710a
Fix MSVC Warnings With “emplace_back()”
...
Several places in the code call `std::vector<aiVector3D>.emplace_back(0, 0, 0)`. The constructor of `aiVector3D` actually expects arguments of the type `ai_real`, (alias of `float` if compiling without `ASSIMP_DOUBLE_PRECISION`) but the literal `0` is of type `int`.
`emplace_back()` does support promotion, but `int` to `float` is a potentially lossy conversion. tl;dr: On warning level 4, MSVC spits out a very deeply nested `warning C4244: 'argument': conversion from '_Ty' to 'TReal', possible loss of data with _Ty=int and TReal=ai_real`.
2023-01-18 00:08:38 +01:00
shimaowo
20acfeaf97
Merge branch 'master' into fix_gltf2_camera_fov
2023-01-17 14:39:54 -08:00
shimaowo
b298b79a46
add missing parens
2023-01-17 10:53:41 -08:00
Martin Mory
7f6e96747b
Merge branch 'master' into f-FixWhitespaceBetweenTagAndNum
2023-01-17 13:32:39 +01:00
Martin Mory
a89d5c7cea
Merge branch 'master' into f-FixWhitespaceBetweenTagAndNum
2023-01-17 12:10:46 +01:00
Kim Kulling
e9f95e5ab6
Merge branch 'master' into fix-build-with-m3d-import-only
2023-01-17 11:22:00 +01:00
Kim Kulling
19dec716d3
Merge branch 'master' into fixJoinVerticesProcess
2023-01-17 09:11:43 +01:00
Krishty
36305cf987
Tidy Up Constructors and Destructors
...
This commit does not add or remove c’tors or d’tors, so it is *not* ABI-breaking.
If a c’tor/d’tor does nothing else than the default behavior, this commit replaces it with “= default”.
If an initializer list entry does nothing else than the default behavior, this commit removes it. First and foremost, remove default c’tor calls of base classes (always called by the compiler if no other base c’tor is explicitly called) and c’tor calls of members with complex types (e.g. “std::vector”).
In a few instances, user-defined copy c’tors / move c’tors / assignment operators / move assignment operators were replaced with “= default”, too. I only did this if I had a clear understanding of what’s going on.
2023-01-16 21:47:11 +01:00
Krishty
43a062a5d7
Remove Stray Semicolon
2023-01-16 20:45:00 +01:00
shimaowo
39cbef1e21
Fix: fix incorrect math for calculating the horizontal FOV of a perspective camera in GLTF2 import #4435
2023-01-16 11:39:13 -08:00