Kim Kulling
ad1d0fcb45
Merge branch 'master' into kimkulling/cleanup_after_review
2022-09-08 19:09:49 +02:00
Kim Kulling
3af53a42aa
Fix typo
2022-09-08 19:06:05 +02:00
Kim Kulling
fff977c0b5
Fix review findings.
2022-09-08 18:54:08 +02:00
Kim Kulling
d475c132bf
Merge pull request #4716 from HiMemX/master
...
Minor obj export bugfix
2022-09-08 12:51:31 +02:00
HiMemX
4c9d270a5e
-Vertex export fix
2022-09-07 23:10:31 +02:00
HiMemX
7872297ab7
Delete ObjExporter.cpp
2022-09-07 23:10:06 +02:00
HiMemX
396e7bcdb4
-Obj vertex fix
2022-09-07 23:09:50 +02:00
Kim Kulling
7116f46672
Add missing file
2022-09-07 21:28:04 +02:00
Kim Kulling
8895ecf243
Merge branch 'master' into kimkulling/cleanup_after_review
2022-09-07 21:26:54 +02:00
Kim Kulling
362ff08855
Add doc + small unittest
2022-09-07 21:25:46 +02:00
Kim Kulling
edaf7fb7eb
Merge pull request #4713 from ChrisBlueStone/master
...
Fix aiBone.mOffsetMatrix documentation
2022-09-05 19:47:02 +02:00
Kim Kulling
af0b29f30d
Merge branch 'master' into master
2022-09-05 19:09:19 +02:00
Kim Kulling
57f4163c67
Merge pull request #4702 from Gargaj/assbinlights
...
add missing light data to assbin import/export
2022-09-05 18:29:59 +02:00
Chris
4b0e38e44f
Fix aiBone.mOffsetMatrix documentation
...
Fixed the comment on the `mOffsetMatrix` property to be correct.
See https://assimp-docs.readthedocs.io/en/latest/API/API-Documentation.html#_CPPv46aiBone
See also https://stackoverflow.com/a/73603994
2022-09-05 11:00:57 -05:00
Gargaj
d15b4ad7ef
add missing light data to assbin import/export
2022-09-05 16:09:24 +02:00
Kim Kulling
fd6c534efc
Merge pull request #4707 from Gargaj/patch-1
...
fix vertices being joined duplicating weights
2022-09-04 10:51:07 +02:00
Kim Kulling
2a667cc637
Merge branch 'master' into patch-1
2022-09-04 09:52:42 +02:00
Kim Kulling
de83245f42
Merge pull request #4703 from Skylion007/explicitly-default-dtors
...
clang-tidy: explicitly default all empty ctors and dtors
2022-09-03 21:25:20 +02:00
Aaron Gokaslan
411171fa45
Apply some more modernize-use-emplace
2022-09-02 11:20:02 -04:00
Aaron Gokaslan
e3b01e10db
apply fixes to more headers
2022-09-01 12:28:45 -04:00
Aaron Gokaslan
4c6652f5b0
Add a handful of missing fixes
2022-09-01 11:37:53 -04:00
Gargaj
a22aa75bca
fix vertices being joined duplicating weights
...
This bug causes weights to duplicate, i.e. one bone will have several (equal) weights assigned to the same vertex - which then has the potential to cause even bigger problems when combined with `LimitBoneWeightsProcess`.
2022-08-31 22:27:34 +02:00
Kim Kulling
f527e56f22
Merge branch 'master' into explicitly-default-dtors
2022-08-30 22:21:06 +02:00
Kim Kulling
80ae9afe4e
Add missing documentation.
2022-08-30 21:55:52 +02:00
Kim Kulling
2c3538fc46
Merge pull request #4705 from assimp/kimkulling/cleanup_after_review
...
[WIP] Code cleanup and some new unittests for edgecases.
2022-08-30 21:54:14 +02:00
Kim Kulling
fbb69df8be
Update utBaseProcess.cpp
2022-08-30 20:54:23 +02:00
Kim Kulling
25d7510b8c
Merge branch 'master' into kimkulling/cleanup_after_review
2022-08-29 22:17:39 +02:00
Kim Kulling
6539b8685f
Update utBaseProcess.cpp
2022-08-29 17:48:57 +02:00
Kim Kulling
e34becff62
Enable portable linkage to fix build
2022-08-29 11:43:32 +02:00
Kim Kulling
8352f0478a
Merge pull request #4704 from JG-Adams/patch-1
...
Wrong object is created here!
2022-08-29 11:23:38 +02:00
Kim Kulling
0571ee21fb
Introduce unittest for BaseProcess.
2022-08-28 20:58:52 +02:00
Kim Kulling
02e6c425f9
Fix ordering of initalizer list
2022-08-27 15:20:53 +02:00
Kim Kulling
e4c383324a
Use string for constexpr
2022-08-27 15:11:54 +02:00
Kim Kulling
14186bcd6b
Code cleanup and some new unittests for edgecases.
2022-08-27 14:07:45 +02:00
J.G.Adams
9cd723e282
Wrong object is created here!
...
If I'm not mistaken. Because this is originally push_back(aniMeshVertex) instead of push_back(v).
And the fact that aniMeshVertex is just getting created and destroyed for nothing.
It need to be replaced with this then? A Clang-tidy syntax to create the same aniMeshVertex.
I found this in pull request #4527 I think it may need to be reviewed too.
2022-08-26 19:12:11 -04:00
Aaron Gokaslan
e93fa6699a
Manually fix up 100 more instances where it should be defaulted
2022-08-25 12:20:13 -04:00
Aaron Gokaslan
6fa21dcc6e
Explicitly default all empty dtors
2022-08-25 11:32:59 -04:00
Kim Kulling
46e571e497
Merge pull request #4700 from Skylion007/skylion007/modernize-use-emplace
...
Apply modernize-use-emplace clang-tidy rule
2022-08-25 10:50:11 +02:00
Kim Kulling
2b30b7e062
Merge branch 'master' into skylion007/modernize-use-emplace
2022-08-24 11:48:30 +02:00
Kim Kulling
066f3f5f14
Merge pull request #4701 from turol/x3d-fixes
...
Fix out of bounds reads in X3D importer
2022-08-24 11:44:50 +02:00
Kim Kulling
659195d852
Fix the fixme
...
- Based on the implementation in top of the last one I guess I know how to fix that.
- Replacing push_back by emplace_back
2022-08-24 11:17:10 +02:00
Turo Lamminen
0d8723a3eb
Add FIXME comment
2022-08-24 10:43:40 +03:00
Turo Lamminen
654ae3af4e
Fix out of bounds access in X3D loader
2022-08-24 10:42:01 +03:00
Kim Kulling
88c69d4edc
Merge pull request #4693 from vkaytsanov/master
...
Remove exception on glTF 2.0 loading
2022-08-23 23:36:26 +02:00
Aaron Gokaslan
25add7baa2
Merge branch 'master' into skylion007/modernize-use-emplace
2022-08-23 15:14:48 -04:00
Kim Kulling
87f601531c
Merge branch 'master' into master
2022-08-23 21:14:45 +02:00
Kim Kulling
aa521569f7
Merge pull request #4699 from turol/smd-fixes
...
SMD fixes
2022-08-23 21:08:42 +02:00
Aaron Gokaslan
b176061c41
Remove extra space in emplace insertions
2022-08-23 11:46:30 -04:00
Aaron Gokaslan
27edb43600
Apply modernize-use-emplace clang-tidy rule
2022-08-23 11:41:49 -04:00
Turo Lamminen
f890bc791f
Fix out of bounds write
2022-08-23 14:38:27 +03:00