From eb452b28a286f706c8936292884c3a35972659e9 Mon Sep 17 00:00:00 2001 From: Alexandre Avenel Date: Sat, 25 Nov 2017 11:38:12 +0100 Subject: [PATCH] Fix warning on MSVC14 --- code/ColladaExporter.cpp | 2 +- code/FindInvalidDataProcess.cpp | 2 +- code/STLLoader.cpp | 4 ++-- code/glTF2Asset.inl | 2 +- code/glTF2Exporter.cpp | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/code/ColladaExporter.cpp b/code/ColladaExporter.cpp index 03a955b8f..4a10d5845 100644 --- a/code/ColladaExporter.cpp +++ b/code/ColladaExporter.cpp @@ -1309,7 +1309,7 @@ void ColladaExporter::WriteAnimationLibrary(size_t pIndex) // Combine the above transformations aiMatrix4x4 mat = TranslationM * RotationM * ScalingM; - for( size_t j = 0; j < 4; ++j) { + for( unsigned int j = 0; j < 4; ++j) { keyframes.insert(keyframes.end(), mat[j], mat[j] + 4); } } diff --git a/code/FindInvalidDataProcess.cpp b/code/FindInvalidDataProcess.cpp index 0113e4c5b..c37d8956c 100644 --- a/code/FindInvalidDataProcess.cpp +++ b/code/FindInvalidDataProcess.cpp @@ -339,7 +339,7 @@ void FindInvalidDataProcess::ProcessAnimationChannel (aiNodeAnim* anim) int FindInvalidDataProcess::ProcessMesh (aiMesh* pMesh) { bool ret = false; - std::vector dirtyMask(pMesh->mNumVertices, pMesh->mNumFaces); + std::vector dirtyMask(pMesh->mNumVertices, pMesh->mNumFaces != 0); // Ignore elements that are not referenced by vertices. // (they are, for example, caused by the FindDegenerates step) diff --git a/code/STLLoader.cpp b/code/STLLoader.cpp index 41f8aad03..ab2dcf36e 100644 --- a/code/STLLoader.cpp +++ b/code/STLLoader.cpp @@ -248,7 +248,7 @@ void STLImporter::LoadASCIIFile( aiNode *root ) { std::vector meshIndices; aiMesh* pMesh = new aiMesh(); pMesh->mMaterialIndex = 0; - meshIndices.push_back( meshes.size() ); + meshIndices.push_back((unsigned int) meshes.size() ); meshes.push_back(pMesh); aiNode *node = new aiNode; node->mParent = root; @@ -383,7 +383,7 @@ void STLImporter::LoadASCIIFile( aiNode *root ) { pScene->mMeshes[ i ] = meshes[i]; } - root->mNumChildren = nodes.size(); + root->mNumChildren = (unsigned int) nodes.size(); root->mChildren = new aiNode*[ root->mNumChildren ]; for ( size_t i=0; imChildren[ i ] = nodes[ i ]; diff --git a/code/glTF2Asset.inl b/code/glTF2Asset.inl index ca18e87e0..246cc1c93 100644 --- a/code/glTF2Asset.inl +++ b/code/glTF2Asset.inl @@ -212,7 +212,7 @@ unsigned int LazyDict::Remove(const char* id) mObjs.erase(mObjs.begin() + index); //update index of object in mObjs; - for (size_t i = index; i < mObjs.size(); ++i) { + for (unsigned int i = index; i < mObjs.size(); ++i) { T *obj = mObjs[i]; obj->index = i; diff --git a/code/glTF2Exporter.cpp b/code/glTF2Exporter.cpp index e6d4d1a3b..c1a803c1f 100644 --- a/code/glTF2Exporter.cpp +++ b/code/glTF2Exporter.cpp @@ -445,7 +445,7 @@ void glTF2Exporter::ExportMaterials() mat->Get(AI_MATKEY_SHININESS, shininess) == AI_SUCCESS ) { // convert specular color to luminance - float specularIntensity = specularColor[0] * 0.2125 + specularColor[1] * 0.7154 + specularColor[2] * 0.0721; + float specularIntensity = specularColor[0] * 0.2125f + specularColor[1] * 0.7154f + specularColor[2] * 0.0721f; //normalize shininess (assuming max is 1000) with an inverse exponentional curve float normalizedShininess = std::sqrt(shininess / 1000);