v4games
/
assimp
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #3346 from assimp/fix_compiler_warnings 

Fix warning: comparison between unsigned and signed.
pull/3328/head^2
Kim Kulling 2020-07-24 11:11:39 +02:00 committed by GitHub
parent 59e15b7fd1 6886ea6c65
commit e8cbc0928e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
test/unit/utglTF2ImportExport.cpp
View File

@ -548,11 +548,9 @@ TEST_F(utglTF2ImportExport, indexOutOfRange) {
// The contents of an asset should not lead to an assert.
Assimp::Importer importer;
struct LogObserver : Assimp::LogStream
{
struct LogObserver : Assimp::LogStream {
bool m_observedWarning = false;
void write(const char *message) override
{
void write(const char *message) override {
m_observedWarning = m_observedWarning || std::strstr(message, "faces were dropped");
}
};
@ -562,8 +560,8 @@ TEST_F(utglTF2ImportExport, indexOutOfRange) {
const aiScene *scene = importer.ReadFile(ASSIMP_TEST_MODELS_DIR "/glTF2/IndexOutOfRange/IndexOutOfRange.gltf", aiProcess_ValidateDataStructure);
ASSERT_NE(scene, nullptr);
ASSERT_NE(scene->mRootNode, nullptr);
ASSERT_EQ(scene->mNumMeshes, 1);
EXPECT_EQ(scene->mMeshes[0]->mNumFaces, 11);
ASSERT_EQ(scene->mNumMeshes, 1u);
EXPECT_EQ(scene->mMeshes[0]->mNumFaces, 11u);
DefaultLogger::get()->detachStream(&logObserver);
EXPECT_TRUE(logObserver.m_observedWarning);
}