v4games
/
assimp
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix: Removing double delete of texture items. 

Textures were being double deleted after a merge scene because the
texture array wasn't being properly deleted at the end of merging.
Furthermore, the texture array was being sized to the number of
materials instead of the number of textures.
pull/3788/head
Scott Baldric 2021-04-22 08:49:47 -05:00
parent 6027c10969
commit aae3788247
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
code/Common/SceneCombiner.cpp
View File

@ -359,7 +359,7 @@ void SceneCombiner::MergeScenes(aiScene **_dest, aiScene *master, std::vector<At
// generate the output texture list + an offset table for all texture indices // generate the output texture list + an offset table for all texture indices
if (dest->mNumTextures) { if (dest->mNumTextures) {
aiTexture **pip = dest->mTextures = new aiTexture *[dest->mNumMaterials]; aiTexture **pip = dest->mTextures = new aiTexture *[dest->mNumTextures];
cnt = 0; cnt = 0;
for (unsigned int n = 0; n < src.size(); ++n) { for (unsigned int n = 0; n < src.size(); ++n) {
SceneHelper *cur = &src[n]; SceneHelper *cur = &src[n];
@ -638,6 +638,8 @@ void SceneCombiner::MergeScenes(aiScene **_dest, aiScene *master, std::vector<At
deleteMe->mMaterials = nullptr; deleteMe->mMaterials = nullptr;
delete[] deleteMe->mAnimations; delete[] deleteMe->mAnimations;
deleteMe->mAnimations = nullptr; deleteMe->mAnimations = nullptr;
delete[] deleteMe->mTextures;
deleteMe->mTextures = nullptr;
deleteMe->mRootNode = nullptr; deleteMe->mRootNode = nullptr;