v4games
/
assimp
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Unit test warning fixes 

GCC was warning about possibly uninitialized variables. Initialize them
and use values which are nonzero and distinct from each other and any
real value passed to any set method. This should prevent any false positives
from zero initialization.
pull/4932/head
Turo Lamminen 2023-02-02 14:05:32 +02:00
parent 6999caa683
commit a2273df48e
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
test/unit/utMetadata.cpp
View File

@ -212,7 +212,7 @@ TEST_F( utMetadata, copy_test ) {
// int32_t test // int32_t test
{ {
int32_t v = 0; int32_t v = 127;
bool ok = copy.Get( "int32", v ); bool ok = copy.Get( "int32", v );
EXPECT_TRUE( ok ); EXPECT_TRUE( ok );
EXPECT_EQ( i32v, v ); EXPECT_EQ( i32v, v );
@ -220,7 +220,7 @@ TEST_F( utMetadata, copy_test ) {
// uint64_t test // uint64_t test
{ {
uint64_t v; uint64_t v = 255;
bool ok = copy.Get( "uint64", v ); bool ok = copy.Get( "uint64", v );
EXPECT_TRUE( ok ); EXPECT_TRUE( ok );
EXPECT_EQ( ui64v, v ); EXPECT_EQ( ui64v, v );
@ -228,14 +228,14 @@ TEST_F( utMetadata, copy_test ) {
// float test // float test
{ {
float v; float v = -9.9999f;
EXPECT_TRUE( copy.Get( "float", v ) ); EXPECT_TRUE( copy.Get( "float", v ) );
EXPECT_EQ( fv, v ); EXPECT_EQ( fv, v );
} }
// double test // double test
{ {
double v; double v = -99.99;
EXPECT_TRUE( copy.Get( "double", v ) ); EXPECT_TRUE( copy.Get( "double", v ) );
EXPECT_EQ( dv, v ); EXPECT_EQ( dv, v );
} }

2
test/unit/utSharedPPData.cpp
View File

@ -81,7 +81,7 @@ TEST_F(SharedPPDataTest, testPODProperty)
EXPECT_FALSE(shared->GetProperty("test2",o)); EXPECT_FALSE(shared->GetProperty("test2",o));
EXPECT_EQ(5, o); EXPECT_EQ(5, o);
float f = 12.f, m; float f = 12.f, m = -98.7654f;
shared->AddProperty("test",f); shared->AddProperty("test",f);
EXPECT_TRUE(shared->GetProperty("test",m)); EXPECT_TRUE(shared->GetProperty("test",m));
EXPECT_EQ(12.f, m); EXPECT_EQ(12.f, m);