From 8ac0af5c58788e48412dc19fca49808fdd357c3f Mon Sep 17 00:00:00 2001
From: Adam Beili <54665621+Beilinson@users.noreply.github.com>
Date: Sun, 26 Mar 2023 17:13:16 +0200
Subject: [PATCH] .

---
 code/AssetLib/glTF2/glTF2Asset.inl       | 2 +-
 code/AssetLib/glTF2/glTF2AssetWriter.inl | 2 +-
 test/unit/utglTF2ImportExport.cpp        | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/code/AssetLib/glTF2/glTF2Asset.inl b/code/AssetLib/glTF2/glTF2Asset.inl
index db773513b..3a3ba376e 100644
--- a/code/AssetLib/glTF2/glTF2Asset.inl
+++ b/code/AssetLib/glTF2/glTF2Asset.inl
@@ -1236,7 +1236,7 @@ inline void Material::Read(Value &material, Asset &r) {
     ReadMember(material, "alphaCutoff", this->alphaCutoff);
 
     if (Value *extensions = FindObject(material, "extensions")) {
-        if (r.extensionsUsed.KHR_materials_pbrSpecularGlossiness) {  //TODO: Maybe ignore this if KHR_materials_specular is also defined
+        if (r.extensionsUsed.KHR_materials_pbrSpecularGlossiness) { 
             if (Value *curPbrSpecularGlossiness = FindObject(*extensions, "KHR_materials_pbrSpecularGlossiness")) {
                 PbrSpecularGlossiness pbrSG;
 
diff --git a/code/AssetLib/glTF2/glTF2AssetWriter.inl b/code/AssetLib/glTF2/glTF2AssetWriter.inl
index ef1c66b3b..f6fc7adff 100644
--- a/code/AssetLib/glTF2/glTF2AssetWriter.inl
+++ b/code/AssetLib/glTF2/glTF2AssetWriter.inl
@@ -424,7 +424,7 @@ namespace glTF2 {
 
             MaterialSpecular &specular = m.materialSpecular.value;
 
-            if (specular.specularFactor != 0.f) {
+            if (specular.specularFactor != 0.0f) {
                 WriteFloat(materialSpecular, specular.specularFactor, "specularFactor", w.mAl);
                 WriteTex(materialSpecular, specular.specularTexture, "specularTexture", w.mAl);
             }
diff --git a/test/unit/utglTF2ImportExport.cpp b/test/unit/utglTF2ImportExport.cpp
index c7d01fbcb..b63fd3944 100644
--- a/test/unit/utglTF2ImportExport.cpp
+++ b/test/unit/utglTF2ImportExport.cpp
@@ -221,7 +221,7 @@ TEST_F(utglTF2ImportExport, importglTF2AndExport_KHR_materials_pbrSpecularGlossi
     EXPECT_NE(nullptr, scene);
     // Export
     ExportProperties props;
-    props.SetPropertyBool(, true);
+    props.SetPropertyBool(AI_CONFIG_USE_GLTF_PBR_SPECULAR_GLOSSINESS, true);
     EXPECT_EQ(aiReturn_SUCCESS, exporter.Export(scene, "glb2", ASSIMP_TEST_MODELS_DIR "/glTF2/BoxTextured-glTF-pbrSpecularGlossiness/BoxTextured_out.glb", 0, &props));
 
     // And re-import