v4games
/
assimp
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[Logger] Log a notification instead of silently dropping long log messages. 

Logs a notification instead of silently dropping long log messages, which can complicate debugging.

This way, if you don't see a message you expect to see, you'll immediately know why.

The *correct* approach would be to eliminate length filtering here entirely and use `snprintf` appropriately (also there's a tiny -- probably negligible -- performance hit here in calling `strlen` regardless of whether or not the verbosity level matches). Failing that, the second best option is to copy and truncate messages here. However, for now, this should be OK.
pull/3896/head
Jason C 2021-05-07 22:32:32 -04:00 committed by GitHub
parent d7c65d363c
commit 859b32c045
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
code/Common/DefaultLogger.cpp
View File

@ -169,7 +169,7 @@ void Logger::debug(const char *message) {
// sometimes importers will include data from the input file // sometimes importers will include data from the input file
// (i.e. node names) in their messages. // (i.e. node names) in their messages.
if (strlen(message) > MAX_LOG_MESSAGE_LENGTH) { if (strlen(message) > MAX_LOG_MESSAGE_LENGTH) {
return; return OnDebug("<fixme: long message discarded>");
} }
return OnDebug(message); return OnDebug(message);
} }
@ -181,7 +181,7 @@ void Logger::verboseDebug(const char *message) {
// sometimes importers will include data from the input file // sometimes importers will include data from the input file
// (i.e. node names) in their messages. // (i.e. node names) in their messages.
if (strlen(message) > MAX_LOG_MESSAGE_LENGTH) { if (strlen(message) > MAX_LOG_MESSAGE_LENGTH) {
return; return OnVerboseDebug("<fixme: long message discarded>");
} }
return OnVerboseDebug(message); return OnVerboseDebug(message);
} }
@ -191,7 +191,7 @@ void Logger::info(const char *message) {
// SECURITY FIX: see above // SECURITY FIX: see above
if (strlen(message) > MAX_LOG_MESSAGE_LENGTH) { if (strlen(message) > MAX_LOG_MESSAGE_LENGTH) {
return; return OnInfo("<fixme: long message discarded>");
} }
return OnInfo(message); return OnInfo(message);
} }
@ -201,7 +201,7 @@ void Logger::warn(const char *message) {
// SECURITY FIX: see above // SECURITY FIX: see above
if (strlen(message) > MAX_LOG_MESSAGE_LENGTH) { if (strlen(message) > MAX_LOG_MESSAGE_LENGTH) {
return; return OnWarn("<fixme: long message discarded>");
} }
return OnWarn(message); return OnWarn(message);
} }
@ -210,7 +210,7 @@ void Logger::warn(const char *message) {
void Logger::error(const char *message) { void Logger::error(const char *message) {
// SECURITY FIX: see above // SECURITY FIX: see above
if (strlen(message) > MAX_LOG_MESSAGE_LENGTH) { if (strlen(message) > MAX_LOG_MESSAGE_LENGTH) {
return; return OnError("<fixme: long message discarded>");
} }
return OnError(message); return OnError(message);
} }