Improved comments.

pull/5007/head
Marc-Antoine Lortie 2023-03-11 22:32:48 -05:00
parent 7bc4c12956
commit 054dacd068
2 changed files with 5 additions and 2 deletions

View File

@ -470,6 +470,7 @@ void HL1MDLLoader::read_bones() {
temp_bones_.resize(header_->numbones); temp_bones_.resize(header_->numbones);
// Create the main 'bones' node that will contain all MDL root bones.
aiNode *bones_node = new aiNode(AI_MDL_HL1_NODE_BONES); aiNode *bones_node = new aiNode(AI_MDL_HL1_NODE_BONES);
rootnode_children_.push_back(bones_node); rootnode_children_.push_back(bones_node);
@ -500,11 +501,11 @@ void HL1MDLLoader::read_bones() {
temp_bones_[i].offset_matrix.Inverse(); temp_bones_[i].offset_matrix.Inverse();
} }
// Create the 'bones' root node that will contain all bone nodes. // Allocate memory for each MDL root bone.
bones_node->mNumChildren = static_cast<unsigned int>(roots.size()); bones_node->mNumChildren = static_cast<unsigned int>(roots.size());
bones_node->mChildren = new aiNode *[bones_node->mNumChildren]; bones_node->mChildren = new aiNode *[bones_node->mNumChildren];
// Build all bones children hierarchy starting from each root bone. // Build all bones children hierarchy starting from each MDL root bone.
for (size_t i = 0; i < roots.size(); ++i) for (size_t i = 0; i < roots.size(); ++i)
{ {
const TempBone &root_bone = temp_bones_[roots[i]]; const TempBone &root_bone = temp_bones_[roots[i]];

View File

@ -81,6 +81,7 @@ public:
ASSERT_NE(nullptr, scene); ASSERT_NE(nullptr, scene);
ASSERT_NE(nullptr, scene->mRootNode); ASSERT_NE(nullptr, scene->mRootNode);
// First, check that "<MDL_root>" and "<MDL_bones>" are linked.
const aiNode* node_MDL_root = scene->mRootNode->FindNode(AI_MDL_HL1_NODE_ROOT); const aiNode* node_MDL_root = scene->mRootNode->FindNode(AI_MDL_HL1_NODE_ROOT);
ASSERT_NE(nullptr, node_MDL_root); ASSERT_NE(nullptr, node_MDL_root);
@ -89,6 +90,7 @@ public:
ASSERT_NE(nullptr, node_MDL_bones->mParent); ASSERT_NE(nullptr, node_MDL_bones->mParent);
ASSERT_EQ(node_MDL_root, node_MDL_bones->mParent); ASSERT_EQ(node_MDL_root, node_MDL_bones->mParent);
// Second, verify "<MDL_bones>" hierarchy.
const Hierarchy expected_hierarchy = { const Hierarchy expected_hierarchy = {
{ 0, AI_MDL_HL1_NODE_BONES }, { 0, AI_MDL_HL1_NODE_BONES },
{ 1, "root1_bone1" }, { 1, "root1_bone1" },